Skip to content

Commit

Permalink
GitBook: [master] 4 pages and 2 assets modified
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanleesipes authored and gitbook-bot committed Jul 8, 2021
1 parent 06be587 commit 6c1efc6
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 11 deletions.
File renamed without changes
4 changes: 2 additions & 2 deletions add-ons/mailextensions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ Developers can share and re-use Experiments, if their add-ons have similar needs
| [TagService](https://github.com/int-red/experiment-api-tagservice) | [B](https://bugzilla.mozilla.org/show_bug.cgi?id=1651954) [💬](https://thunderbird.topicbox.com/groups/addons/T748f8fbd94681aa6-Me57c565c9f0111b493771c77) | Add/Manage email tags. |
| [TCP](https://github.com/rsjtdrjgfuzkfg/thunderbird-experiments/tree/master/experiments/tcp) | | TCP support based on ArrayBuffers \(currently client side only\). |

💬: API has a public announcement post
💬: API has a public announcement post
📝: API has a public interface discussion
B : Bugzilla Bug
B : Bugzilla Bug

If you have created an Experiment API which you think could be beneficial to other developers, please [tell us about it](https://github.com/thundernest/developer-docs/issues/new), so we can include it here.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ During installation make sure the following workloads are checked:

### MozillaBuild Package

Finally, download the [MozillaBuild Package](https://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe) from Mozilla. Accept the default settings, in particular the default installation directory: `c:\mozilla-build\`. On some versions of Windows an error dialog will give you the option to ‘reinstall with the correct settings’ - you should agree and proceed.
Finally, download the [MozillaBuild Package](https://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe) from Mozilla. Accept the default settings, in particular the default installation directory: `c:\mozilla-build\`. On some versions of Windows an error dialog will give you the option to ‘reinstall with the correct settings’ - you should agree and proceed.

{% hint style="info" %}
Once this is done, creating a shortcut to `c:\mozilla-build\start-shell.bat` on your desktop will make your life easier.
Once this is done, creating a shortcut to `c:\mozilla-build\start-shell.bat` on your desktop will make your life easier.
{% endhint %}

{% hint style="success" %}
Expand Down
14 changes: 7 additions & 7 deletions thunderbird-development/fixing-a-bug/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ The majority of the Thunderbird developers use queues as they're easy to import

The commit message should be of the form:

```
```text
Bug xxxx - Short description of your change. r?reviewer
Optionally, a longer description of the change.
Expand All @@ -73,17 +73,17 @@ There is a command line tool, `moz-phab`, which makes it easy to submit local ch

See the [moz-phab setup and installation](https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#setting-up-mozphab) docs.

With `moz-phab` you can submit local mercurial changeset(s) like this:
With `moz-phab` you can submit local mercurial changeset\(s\) like this:

```
```text
$ moz-phab submit [start_changeset] [end_changeset]
```

The start/end changesets are optional, and if omitted `moz-phab` will guess which ones you're likely to mean.

It'll ask for confirmation before uploading, so don't worry too much about accidental submissions.

`moz-phab` will pick the bug number out of the commit message (`Bug xxxx`), and link back to the bugzilla bug. If there is a reviewer (`r?...`), it will automatically assign them and send them a notification. You can leave the reviewer out, but then one will have to be manually assigned via the phabricator web page.
`moz-phab` will pick the bug number out of the commit message \(`Bug xxxx`\), and link back to the bugzilla bug. If there is a reviewer \(`r?...`\), it will automatically assign them and send them a notification. You can leave the reviewer out, but then one will have to be manually assigned via the phabricator web page.

You can find more details in the `moz-phab` [README](https://github.com/mozilla-conduit/review/blob/master/README.md#submitting-commits-to-phabricator).

Expand All @@ -95,11 +95,11 @@ This still works, but Phabricator is now the preferred method.

## Updating patches

It's very common for patches to require some updates before being accepted.
Locally, you can use `hg commit --amend` to update a changeset.
It's very common for patches to require some updates before being accepted. Locally, you can use `hg commit --amend` to update a changeset.

Phabricator tracks uploaded patches by adding a line to the commit message:
```

```text
Differential Revision: <url>
```

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,23 @@ In this session Alessandro works on fixing a bug with folders in Thunderbird, he

{% embed url="https://youtu.be/XD8BzmsM-iU" %}

## Compose Window and Inspecting UI Elements

In this session Alessandro works on fixing some compose window bugs and explains how to work with the compose window interface and inspect the Thunderbird interface elements.

{% embed url="https://youtu.be/wCaJG0jupE8" %}

## Changing How Attachments Work

In this session Alessandro works on changing how attachments are displayed when composing in Thunderbird.

{% embed url="https://youtu.be/V1lQa8bEgls" %}

## Compose Window and Attachment UI

In this session Alessandro continues improvements to the compose windows and attachment interface. He also dives in-depth on styles and other bits that make up how the UI is built.

{% embed url="https://youtu.be/fXofonRxCAY" %}



0 comments on commit 6c1efc6

Please sign in to comment.