-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various additions #2
Conversation
2380584
to
d503177
Compare
ae0356f
to
86a3bcc
Compare
bcd254e
to
567bf41
Compare
23234df
to
8792458
Compare
8792458
to
2eb28cc
Compare
@hjiangsu Just tagging you on this to let you know I've gotten the server in a good enough place that I think I can daily drive UnifiedPush notifications! We'll see how things go. 😊 |
|
||
import { UnifiedPushObject } from "./../../types/unified_push_object"; | ||
|
||
setGlobalDispatcher(new Agent({connect: { timeout: 30_000 }})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I increased this timeout as it seems like my ntfy server is a little slower than the official one. However, it's concerning to me that a timeout can crash the whole server. Is there any way for us to automatically recover and/or retry? This is where my already non-existent node knowledge falls flat. 😊
Thanks for the additions, especially the docker workflow!
There's a few ways to do this! Typically, we can just add a try-catch on the function that caused the error. Then, we can create a queue (if needed) to automatically retry again. Or in our case, we can update the database table record (specifically, the Could you provide a bit more details on the timeout issue you're encountering? I might be able to find an alternate solution here! |
What do you think about putting a try/catch around all of
Sure! I was getting this exception from
|
I pushed another change which fixes the sort type when retrieving notifications. Because it wasn't sorted by |
I pushed another commit which uses the slimmer payload object for reply notifications. |
This PR makes a few enhancements for the Thunder server.
main
branch will be tagged withlatest
so that they will automatically work for people pulling with no tag. (https://github.com/thunder-app/thunder_server/pkgs/container/thunder_server)fetch
timeout as I was having issues talking to ntfy.I'm going to leave this PR as a draft until I can get the service up and running for myself! EDIT: Actually it looks like drafts aren't configured. 😕