Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native lazy-loading support #688

Closed
wants to merge 16 commits into from
Closed

Add native lazy-loading support #688

wants to merge 16 commits into from

Conversation

danoc
Copy link
Member

@danoc danoc commented Jun 9, 2020

No description provided.

Base automatically changed from daniel/prettier-upgrade to master June 10, 2020 20:12
@danoc danoc marked this pull request as ready for review June 12, 2020 21:41
@danoc danoc requested a review from lavelle June 12, 2020 21:41
@danoc
Copy link
Member Author

danoc commented Jun 13, 2020

Sorry for the noise here. This is good for review!

lavelle
lavelle previously approved these changes Jun 15, 2020
@danoc
Copy link
Member Author

danoc commented Jun 15, 2020

I'm starting to realize this won't be as impactful as I hoped.

Two issues:

This CR does improve performance on pages that have heavy use of carousels. But we can fix the carousel bug separately and see performance improvements without these downsides.

@danoc danoc closed this Jun 15, 2020
@danoc danoc deleted the daniel/image-lazy-load branch June 15, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants