-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper font in GoAT diagrams #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I think that this change introduces a bug with
without that
Happy to put up a PR or file an issue, but also not fully sure if that's actually a fix or not first (I'm still learning hugo things) |
@bigethan I cannot reproduce the error you post. E.g. Note that for our Anyways, I don't know much about Hugo's internals incl. I would recommend to try to reproduce the issue with a minimal setup. If the problem stays the same, ask on the official Hugo forum. If you can't reproduce it outside of Doks, open a new issue here. :) To generate a new folder hugo new theme my-new-site --themesDir . |
Addendum: I was curious and tested putting a dot before Are you using an old version of Hugo? |
gah, I got my wires crossed. Doks comes with a command Thanks for talking me through this, lotsa new stuff to learn/break never quite sure what's happening yet. |
Yeah, hugo-installer, which Doks uses, is really not the "best of all worlds", to put it mildly. I'd recommend to use hvm instead and adapt the npm script commands in your project accordingly. hvm registers the Hugo version to use in an
You're welcome. Hugo is a really powerful tool, but generally a pain to learn, mostly due to subpar and missing documentation. I guess everyone not already proficient in Golang has +/- this same bad experience. Fortunately, the problem has been recognized by Hugo's main devs and the basics for better documentation are being laid. Especially Joe Mooring really cares and does a lot of the tedious groundwork that is needed for Hugo to become more accessible for outsiders. |
Summary
Font is hardcoded in Hugo's default
goat
code block render hook, thus we include a modifed version that uses Doks' default fonts.Basic example
Motivation
Aesthetics
To do
GoAT diagrams are awesome, I think they should be mentioned in Doks' documentation.
Checks
npm run test