Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vae_ssl: variable name issue and n not match #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix vae_ssl: variable name issue and n not match #127

wants to merge 1 commit into from

Conversation

csy530216
Copy link
Collaborator

Two issues in vae_ssl.py and vae_ssl_adaptive_is.py are fixed now:

  1. The variable names x_labeled and x_unlabeled were reused.
  2. The n in modelling of unlabeled part in vae_ssl.py should be n * n_class.

@csy530216 csy530216 mentioned this pull request Jan 9, 2020
Open
thjashin
thjashin reviewed Jan 12, 2020
View reviewed changes
examples/semi_supervised_vae/vae_ssl.py
variational=variational,
axis=0))

# Unlabeled
# TODO: n not match.

unlabeled_model = build_gen(n * n_class, x_dim, n_class, z_dim, n_particles)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd better not rebuild the model? other workaround possible? @csy530216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjashin thjashin thjashin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csy530216 @thjashin