fix: dont swallow merkle update worker errors #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pepyakin
force-pushed
the
pep-fix-avoid-o_direct-on-tmpfs
branch
from
5bcd043
to
4ad3ffe
Compare
pepyakin
force-pushed
the
pep-fix-dont-swallow-merkle-update-worker-errors
branch
from
39cb3c8
to
3deff82
Compare
pepyakin
force-pushed
the
pep-fix-avoid-o_direct-on-tmpfs
branch
from
4ad3ffe
to
1e69054
Compare
pepyakin
force-pushed
the
pep-fix-dont-swallow-merkle-update-worker-errors
branch
from
3deff82
to
1b50dce
Compare
rphmeier
approved these changes
Dec 3, 2024
rphmeier
changed the base branch from
pep-fix-avoid-o_direct-on-tmpfs
to
graphite-base/591
instead, bubble them up in the loop. This still requires a better error handling approach.
rphmeier
force-pushed
the
pep-fix-dont-swallow-merkle-update-worker-errors
branch
from
1b50dce
to
9565493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead, bubble them up in the loop. This still requires
a better error handling approach.