Create GitHub actions workflow to run tests #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Flaky since they rely on the sha256 fingerprint, which changes over time
it is required to run commands such as `.blank?`. Previously it was being installed upstream in the deprecated case_transform gem
- tests still failing locally...
codecov is no longer configured, is not free, and is currently blocking running tests in CI
mattwr18
changed the title
roschaefer
approved these changes
May 3, 2024
|
|
||
| spec.files = Dir['{lib}/**/*'] | ||
| spec.require_paths = ['lib'] | ||
|
|
||
| spec.add_runtime_dependency 'case_transform' | ||
| spec.add_runtime_dependency 'activesupport', '~> 7.0.8' |
There was a problem hiding this comment.
It would be nice to only import active support's string inflections. But I'm not aware how this is possible in Ruby land.
| # this is needed due to internet access restrictions | ||
| # in the (travis) CI environment | ||
| # skipped in CI because this test requires actual | ||
| # private key, identity, etc set in .env variables |
There was a problem hiding this comment.
And that's the only spec that fails on my machine locally. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed in this PR and why
case_transformgem's reliance on activesupport 7.1 and the error:The gem was removed as it was only used in two files and transforms the case in a way that we can do without an extra gem.
activesupportgem was added because we use methods that we were inheriting fromcase_transformdependency onactivesupport, ie.blank?