Drop record states #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
approved these changes
Jan 16, 2018
routemaster/db/model.py
Outdated
| Column('name', String, primary_key=True), | ||
| Column('updated', DateTime), | ||
| Column('id', Integer, primary_key=True, autoincrement=True), | ||
| Column('name', String), |
There was a problem hiding this comment.
While I'm not sure what model we're after, I wonder whether this column should be unique?
There was a problem hiding this comment.
Not for what James and I were trying to get to when we came up with this iteration. Old state machines would not be resurrected, a new one would be created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is temporary. There is an ongoing discussion about the best data export format.
When work starts to re-introduce this, reverting d8a33d8 should provide a good starting point with failing tests.