Rename for clarity

thread · Jan 4, 2018 · 606b673 · 606b673
1 parent e485628
commit 606b673
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/routemaster/context.py b/routemaster/context.py
@@ -73,4 +73,4 @@ def _pre_warm_feeds(self, label: str, accessed_variables: Iterable[str]):
 
             feed = self.feeds.get(parts[1])
             if feed is not None:
-                feed.fetch(label)
+                feed.prefetch(label)
diff --git a/routemaster/feeds.py b/routemaster/feeds.py
@@ -28,7 +28,7 @@ def __init__(self, url, state_machine):
         self.data = None
         self.state_machine = state_machine
 
-    def fetch(self, label: str):
+    def prefetch(self, label: str):
         """Trigger the fetching of a feed's data."""
         if self.data is not None:
             return

diff --git a/routemaster/tests/test_feeds.py b/routemaster/tests/test_feeds.py
@@ -44,9 +44,9 @@ def test_fetch_only_once():
     feed = Feed('http://example.com/<state_machine>/<label>', 'test_machine')
 
     with mock.patch('requests.Response.json') as json:
-        feed.fetch('label1')
-        feed.fetch('label1')
-        feed.fetch('label1')
+        feed.prefetch('label1')
+        feed.prefetch('label1')
+        feed.prefetch('label1')
 
         assert json.call_count == 1
 
@@ -61,7 +61,7 @@ def test_lookup():
     )
 
     feed = Feed('http://example.com/<state_machine>/<label>', 'test_machine')
-    feed.fetch('label1')
+    feed.prefetch('label1')
 
     assert feed.lookup(('foo',)) == 'bar'