-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci-lint/CI: Bump versions and introduce new linters #798
Conversation
21b4d95
to
218715a
Compare
218715a
to
c9a0444
Compare
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
==========================================
- Coverage 43.68% 43.38% -0.31%
==========================================
Files 311 311
Lines 80042 80287 +245
==========================================
- Hits 34967 34833 -134
- Misses 39936 40214 +278
- Partials 5139 5240 +101
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome update! 🚀 x 100. Just a couple of nits below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested approved. This is a great update! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely big PR that looks like it wasn't fun to do! Thanks!
My concerns are only len related and only because its type checking after type checking. Not much of a big deal
One extra thing as a favour is that there are a few instances of the following: *int64(time.Millisecond)
where the implementation can now be changed from time.Unix(0, ...*int64(time.Millisecond))
to time.UnixMilli(...)
For example, bitfinex_websocket time.Unix(0, int64(element[0].(float64))*int64(time.Millisecond)),
edit: as this is about linters, the linters themselves pass. So I'm happy for you to say "later" and change this to tACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Thanks for making those changes + the unixMilli ones too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! 🥇
PR Description
Bumps golangci-lint/CI Go versions and introduces a few new linters!
Type of change
How has this been tested
Checklist