engine/gRPC: Add update account info to grpc interface #602
Conversation
There was a problem hiding this comment.
Nice update 👍
I have tested exchanges I have keys on:
- Binance
- Kraken
- Bitfinex
- Bitmex
- Coinut
- HitBTC
- Okcoin
- Okex
Found some Out Of Scope Issues:
- Appending to currency list without any balance is very verbose console side from GRPC
- go run ./... updateaccountinfo coinut
2020/11/26 15:39:06 rpc error: code = Unknown desc = COINUT websocket connection: timeout waiting for response with signature: 4868563
exit status 1 - {
"currency": "XRP",
"total_value": 1234.1234 // Think this needs to change to amount in okex and okcoin.
}
Thank you very much for opening this PR 🎉
engine/rpcserver_test.go
Outdated
|
|
||
| r, err := s.GetAccountInfo(context.Background(), &gctrpc.GetAccountInfoRequest{Exchange: fakePassExchange}) | ||
| if err != nil { | ||
| t.Errorf("TestGetAccountInfo: Failed to get account info: %w", err) |
There was a problem hiding this comment.
You can do t.Fatalf saves you doing return afterward.
engine/rpcserver_test.go
Outdated
|
|
||
| func cmpAccounts(t *testing.T, exp []account.SubAccount, act []*gctrpc.Account) { | ||
| if len(act) != len(exp) { | ||
| t.Errorf("TestGetAccountInfo: Unexpected number of accouns in the response: exp=%d, act=%d", len(exp), len(act)) |
|
Sweet, thanks for making those changes so quickly! One more thing I've noticed that our build is having linter issues: |
|
sure |
There was a problem hiding this comment.
tACK! Thanks for making those changes and thank you for your contribution @mshogin!
thrasher-
changed the title
There was a problem hiding this comment.
tACK, thanks @mshogin for this new feature plus also for resolving the lbank OB issue!
./gctcli updateaccountinfo --exchange=binance
{
"exchange": "Binance",
"accounts": [
{
"currencies": [
{
"currency": "BTC",
"total_value": xxx
...
|
Thank you |
PR Description
This patch add support of UpdateAccountInfo to the GRPC server.
It is useful to have actual account state for the preliminary validation of the bid request.
Without such possibility we have to send requests to the exchange and either use completed orders for keeping account up to date or handle error messages from the exchange.
Type of change
How has this been tested
Added tests to the engine/rpcserver_test.go
Checklist