Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set go.mod/go.sum file line endings to LF #391

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

thrasher-
Copy link
Collaborator

Description

Introduces a .gitattributes file which sets go.mod/go.sum line endings to LF based off the discussion in: golang/go#31870

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules

Saves having Windows users experience pain and suffering as documented
here:

golang/go#31870
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #391 into engine will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           engine     #391      +/-   ##
==========================================
+ Coverage   41.42%   42.09%   +0.67%     
==========================================
  Files         167      167              
  Lines       38207    39900    +1693     
==========================================
+ Hits        15827    16796     +969     
- Misses      21274    21931     +657     
- Partials     1106     1173      +67
Impacted Files Coverage Δ
exchanges/coinbasepro/coinbasepro.go 34.2% <0%> (-0.55%) ⬇️
exchanges/zb/zb.go 71.42% <0%> (-0.37%) ⬇️
exchanges/btcmarkets/btcmarkets.go 58.72% <0%> (-0.2%) ⬇️
exchanges/huobi/huobi_websocket.go 0% <0%> (ø) ⬆️
engine/orders.go 0% <0%> (ø) ⬆️
logger/logger_types.go 100% <0%> (ø) ⬆️
exchanges/asset/asset.go 100% <0%> (ø) ⬆️
exchanges/okgroup/okgroup.go 11.83% <0%> (+0.27%) ⬆️
dispatch/mux.go 94.11% <0%> (+0.36%) ⬆️
currency/code.go 75.49% <0%> (+0.4%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5d75b...eedb97a. Read the comment docs.

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK!

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. May I never have to revert go.mod changes again

Copy link
Contributor

@xtda xtda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
tested approved

@thrasher- thrasher- merged commit 49b9ece into engine Dec 3, 2019
@thrasher- thrasher- deleted the engine_le branch December 3, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants