-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Engine) Variety of engine updates #390
Conversation
…d the json package directly. WRT unmarshal it was calling reflect and converted to string which is also checked in the JSON package so it was doing a double up, this will be a tiny gain as it was directly used in the requester package for all our outbound requests.
Codecov Report
@@ Coverage Diff @@
## engine #390 +/- ##
=========================================
- Coverage 41.44% 41.4% -0.05%
=========================================
Files 167 167
Lines 38224 38207 -17
=========================================
- Hits 15842 15818 -24
- Misses 21276 21281 +5
- Partials 1106 1108 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Good stuff 🐑🐑🐑🐑🐑🐑🐑🐑🐺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicee!!!
Description
Just little changes I found when looking at the totality of the engine branch compared to master.
Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How Has This Been Tested?
locally
Checklist: