Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Engine) Variety of engine updates #390

Merged
merged 14 commits into from
Dec 2, 2019

Conversation

shazbert
Copy link
Collaborator

@shazbert shazbert commented Dec 2, 2019

Description

Just little changes I found when looking at the totality of the engine branch compared to master.

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules

@shazbert shazbert self-assigned this Dec 2, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #390 into engine will decrease coverage by 0.04%.
The diff coverage is 22.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##           engine    #390      +/-   ##
=========================================
- Coverage   41.44%   41.4%   -0.05%     
=========================================
  Files         167     167              
  Lines       38224   38207      -17     
=========================================
- Hits        15842   15818      -24     
- Misses      21276   21281       +5     
- Partials     1106    1108       +2
Impacted Files Coverage Δ
dispatch/mux.go 93.75% <ø> (ø) ⬆️
engine/connection.go 64.51% <ø> (ø) ⬆️
exchanges/btse/btse_websocket.go 0% <0%> (ø) ⬆️
exchanges/alphapoint/alphapoint.go 17.59% <0%> (ø) ⬆️
exchanges/itbit/itbit.go 62.17% <0%> (ø) ⬆️
exchanges/zb/zb_websocket.go 1.87% <0%> (ø) ⬆️
exchanges/request/request.go 72.24% <0%> (ø) ⬆️
exchanges/hitbtc/hitbtc_websocket.go 0% <0%> (ø) ⬆️
exchanges/lakebtc/lakebtc.go 55.17% <0%> (ø) ⬆️
exchanges/bitstamp/bitstamp_websocket.go 0% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bddcc...194a2db. Read the comment docs.

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Good stuff 🐑🐑🐑🐑🐑🐑🐑🐑🐺

@shazbert shazbert mentioned this pull request Dec 2, 2019
10 tasks
Copy link
Collaborator

@thrasher- thrasher- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 👍

Copy link
Contributor

@xtda xtda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Contributor

@MadCozBadd MadCozBadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee!!!

@thrasher- thrasher- merged commit 0c5d75b into thrasher-corp:engine Dec 2, 2019
@shazbert shazbert deleted the engine_updates branch December 3, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants