Bump golangci-lint to v1.18.0

[thrasher-]

Description

Bumps golangci-lint to v1.18.0

AppVeyor only supports Go 0.12.3 for Windows and 0.12.7 on Linux, though I assume their stack will be updated shortly.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

go test ./... -race and CI

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally and on Travis with my changes
• Any dependent changes have been merged and published in downstream modules

[shazbert]

Awesome bump-de-bump!
tACK - local CI update to 1.18 and build/run

[xtda]

Might be outside the scope but

gocryptotrader/Makefile

Line 13 in 0b69b9c

GO111MODULE=on go get $(GCTPKG)

is redundant because to even execute this make file you already have GCT (either via go get which would have already pulled the files down) or cloning the repo

Same with the "get" make target

Other than that tested no linter issues

Approved

[thrasher-]

Might be outside the scope but

gocryptotrader/Makefile

Line 13 in 0b69b9c

GO111MODULE=on go get $(GCTPKG)

is redundant because to even execute this make file you already have GCT (either via go get which would have already pulled the files down) or cloning the repo

Same with the "get" make target

Other than that tested no linter issues

Approved

Will do that in a separate makefile update as I wish to add more flags to it for engine (protobuff generation, version override and a few other things)

[gloriousCode]

Tested, approved, no lint errors 🍨 🌹 🚌

[MadCozBadd]

notications -> notifications

[thrasher-]

Update pushed 👍