Migrate from gometalinter.v2 to golangci-lint #249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 42.27% 42.36% +0.09%
==========================================
Files 120 120
Lines 26094 26078 -16
==========================================
+ Hits 11032 11049 +17
+ Misses 14144 14124 -20
+ Partials 918 905 -13
Continue to review full report at Codecov.
|
thrasher-
force-pushed
the
golangci-linter
branch
2 times, most recently
from
9237b24 to
265b295
Compare
thrasher-
force-pushed
the
golangci-linter
branch
from
265b295 to
0799d7c
Compare
| for _, exch := range c.Exchanges { | ||
| if exch.Name == exchangeName { | ||
| for _, account := range exch.BankAccounts { | ||
| for x := range c.Exchanges { |
There was a problem hiding this comment.
Is iterating on the index vs putting it in a variable here better practice, more efficient or both?
There was a problem hiding this comment.
An index or pointer is the most efficient, doing it the original way allocates an exchange config object per iteration.
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
| @@ -317,10 +318,12 @@ func TestProcessTicker(t *testing.T) { //non-appending function to tickers | |||
|
|
|||
| for _, test := range testArray { | |||
| wg.Add(1) | |||
| fatalErr := false | |||
There was a problem hiding this comment.
Every exported function in a program should have a doc comment. The first sentence should be a summary that starts with the name (TestProcessTicker) being declared.
From effective go.
|
tACK |
Description
Due to gometalinter now being EOL, this PR migrates us over to golangci-linter. The benefits are that it's quicker, supports more linters and is easily customisable by a config file. To start, 19 linters have been enabled but over time we will aim to add more.
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How Has This Been Tested?
Travis and make check
Checklist: