Makefile: add new recipes and linter features #244
Conversation
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 42.27% 42.34% +0.06%
==========================================
Files 122 122
Lines 24811 24732 -79
==========================================
- Hits 10490 10473 -17
+ Misses 13430 13371 -59
+ Partials 891 888 -3
Continue to review full report at Codecov.
|
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
thrasher-
force-pushed
the
makefile
branch
2 times, most recently
from
b990022 to
e60cd07
Compare
| return true | ||
| } | ||
| return false | ||
| return (p == (APIKeyParams{})) |
| return true | ||
| } | ||
| return false | ||
| return (p == (ChatGetParams{})) |
| return true | ||
| } | ||
| return false | ||
| return (p == (ChatSendParams{})) |
| return true | ||
| } | ||
| return false | ||
| return (p == (GenericRequestParams{})) |
| return true | ||
| } | ||
| return false | ||
| return (p == (UserRequestWithdrawalParams{})) |
portfolio/portfolio.go
Outdated
| return false | ||
| } | ||
| return true | ||
| return (errors == 0) |
| @@ -261,16 +258,16 @@ func (p *Base) GetPersonalPortfolio() map[string]float64 { | |||
| // getPercentage returns the percentage of the target coin amount against the | |||
| // total coin amount. | |||
| func getPercentage(input map[string]float64, target string, totals map[string]float64) float64 { | |||
There was a problem hiding this comment.
RM map[string]float64 type dec. for input var.
There was a problem hiding this comment.
Gonna leave this one as is since the target is of type string
There was a problem hiding this comment.
How about
func getPercentage(target, totals map[string]float64, target string) float64
?
There was a problem hiding this comment.
Out of scope for this PR, there's probabably a lot of others like this but is insignificant. Malalignment checks (mainly for structs) can be done in the future.
|
@shazbert all nitterinos resolved 👍 |
|
utACK WELL DONE SIR! |
Description
Introduces a new makefile with various recipes.
Type of change
How Has This Been Tested?
Travis and individual recipe testing.
Checklist: