Config: AssetEnabled upgrade #1735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbjk
force-pushed
the
feature/config_assetenabled
branch
2 times, most recently
from
3697ede to
5fb08d2
Compare
gloriousCode
added
the
nomerge requires dependency
gbjk
force-pushed
the
feature/config_assetenabled
branch
from
026f88f to
272827a
Compare
gbjk
force-pushed
the
feature/config_assetenabled
branch
from
942b49b to
e2d81d0
Compare
gbjk
removed
the
nomerge requires dependency
This became more messy with Disabling something that's defaulted to disabled. Taking an idealogical stance against erroring that what you want to have done is already done.
Previously we were calling it "Format", but accepting everything from the PairStore. We were also defaulting to turning the Asset on. Now callers need to get their AssetEnabled set as they want it, so there's no magic This change also moves responsibility for error wrapping outside to the caller.
Previously we ignored the field and just turned on everything. I think that was because we couldn't get at the old value. In either case, we have the option to do better, and respect the assetEnabled value
shazbert
requested changes
Dec 13, 2024
gbjk
force-pushed
the
feature/config_assetenabled
branch
from
c092bfa to
65c05a0
Compare
Fixed gbjk@65c05a063 |
gbjk
force-pushed
the
feature/config_assetenabled
branch
from
65c05a0 to
4a4fb99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config:
Exchanges:
StoreAssetPairFormattoStoreAssetPairStoreSetAssetEnabledwill not error on no-op (already disabled or enabled)Bitfinex:
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested