Assets: Fix LinearContracts support #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbjk
force-pushed
the
bugfix/linear_assets
branch
3 times, most recently
from
5b33bc5 to
55d5ba8
Compare
shazbert
requested changes
Nov 23, 2024
gloriousCode
requested changes
Nov 24, 2024
gloriousCode
approved these changes
Nov 25, 2024
supportedFlag&a is true for every even number, making the test pretty close to meaningless. [This fix](5b33bc5) was a viable fix maintaining bit shifted iota, but there's no benefit to it at all. Simplifying.
gbjk
force-pushed
the
bugfix/linear_assets
branch
from
9b000bd to
c6f39af
Compare
|
Rebase-Squashed. |
thrasher-
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Simplifies the package (as per our discussion in the past of bitshifting values and how people can be confused by it) but at the cost of specific ordering with our consts. This is going to be overhauled again as per issue #1691 so LGTM
gbjk
added a commit
to gbjk/gocryptotrader
that referenced
this pull request
Nov 26, 2024
* Assets: Fix LinearContracts support * Assets: Fix False positives with IsValid supportedFlag&a is true for every even number, making the test pretty close to meaningless. [This fix](5b33bc5) was a viable fix maintaining bit shifted iota, but there's no benefit to it at all. Simplifying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Linear assets missing from list of strings for asset conversion.
Drive-Bys a couple of other minor fixes from another branch that shouldn't be contentious.
Type of change
How has this been tested