Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types/time: filter string that cannot be a unix timestamp #1715

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

shazbert
Copy link
Collaborator

@shazbert shazbert commented Nov 12, 2024

PR Description

Did not error when using incorrect type. So force check, more performant using time.Time type for that use case so not going to handle potential edge case.

Cherry-picked from #1670

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

  • go test ./... -race
  • golangci-lint run
  • Test X

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Github Actions with my changes
  • Any dependent changes have been merged and published in downstream modules

@shazbert shazbert added the review me This pull request is ready for review label Nov 12, 2024
@shazbert shazbert requested a review from a team November 12, 2024 03:50
@shazbert shazbert self-assigned this Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.11%. Comparing base (8f9ebcb) to head (a83034e).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
- Coverage   37.13%   37.11%   -0.03%     
==========================================
  Files         414      414              
  Lines      180177   180186       +9     
==========================================
- Hits        66910    66868      -42     
- Misses     105411   105457      +46     
- Partials     7856     7861       +5     
Files with missing lines Coverage Δ
types/time.go 94.64% <100.00%> (-5.36%) ⬇️

... and 14 files with indirect coverage changes

@shazbert shazbert added the bug label Nov 13, 2024
types/time_test.go Outdated Show resolved Hide resolved
Co-authored-by: Adrian Gallagher <[email protected]>
Copy link
Collaborator

@thrasher- thrasher- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes

Copy link
Collaborator

@cranktakular cranktakular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that newest change, everything looks good!

types/time.go Outdated Show resolved Hide resolved
types/time.go Outdated Show resolved Hide resolved
types/time.go Outdated Show resolved Hide resolved
@shazbert shazbert requested a review from gloriousCode December 3, 2024 03:10
Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tack

@thrasher- thrasher- merged commit b98e82d into thrasher-corp:master Dec 3, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review me This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants