Huobi: Fix invalid contract type error when autoUpdatePairs is false #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1707 +/- ##
==========================================
+ Coverage 37.07% 37.09% +0.02%
==========================================
Files 414 414
Lines 180275 180282 +7
==========================================
+ Hits 66828 66874 +46
+ Misses 105589 105556 -33
+ Partials 7858 7852 -6
|
gloriousCode
requested changes
Nov 10, 2024
gbjk
force-pushed
the
bugfix/huobi_cw
branch
from
6afccd2 to
1ea8fd4
Compare
gbjk
force-pushed
the
bugfix/huobi_cw
branch
2 times, most recently
from
5264e09 to
ccdcf0e
Compare
We were relying on autoUpdatePairs to fetch contract types before we need them. If the user disables it in config, we'll get them upfront.
gbjk
force-pushed
the
bugfix/huobi_cw
branch
from
ccdcf0e to
c36bb36
Compare
Done. |
thrasher-
changed the title
thrasher-
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Thanks for resolving this + @gloriousCode for test coverage C+P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were relying on autoUpdatePairs to fetch contract types before we need them. If the user disables it in config, we'll lazily fetch just the relevant Futures.
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested