Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HitBTC: Add Subscription Configuration #1639

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Sep 3, 2024

HitBTC

  • Add Subscription configuration
  • Upgrade test configuration

New Library Dependencies

  • sprig ( Also included in 4 other template PRs )

Type of change

  • New feature (non-breaking change which adds functionality)

@gbjk gbjk self-assigned this Sep 3, 2024
@gbjk gbjk force-pushed the feature/hitbtc_sub_conf branch 2 times, most recently from 3706452 to 4b6d747 Compare September 3, 2024 07:22
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 50.94340% with 26 lines in your changes missing coverage. Please review.

Project coverage is 36.51%. Comparing base (cb6b342) to head (4b6d747).

Files with missing lines Patch % Lines
exchanges/hitbtc/hitbtc_websocket.go 45.83% 23 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1639   +/-   ##
=======================================
  Coverage   36.50%   36.51%           
=======================================
  Files         414      414           
  Lines      179353   179322   -31     
=======================================
- Hits        65477    65471    -6     
+ Misses     106006   105965   -41     
- Partials     7870     7886   +16     
Files with missing lines Coverage Δ
exchanges/hitbtc/hitbtc_wrapper.go 45.73% <100.00%> (+0.36%) ⬆️
exchanges/subscription/subscription.go 100.00% <ø> (ø)
exchanges/hitbtc/hitbtc_websocket.go 29.67% <45.83%> (+4.46%) ⬆️

... and 19 files with indirect coverage changes

@gbjk gbjk added the review me This pull request is ready for review label Sep 3, 2024
@gbjk gbjk force-pushed the feature/hitbtc_sub_conf branch from 4b6d747 to 0e80320 Compare September 18, 2024 06:54
@gbjk gbjk force-pushed the feature/hitbtc_sub_conf branch from 0e80320 to d17bfc3 Compare December 4, 2024 07:43
Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested auth and unauth. just one thing

exchanges/hitbtc/hitbtc_websocket.go Show resolved Hide resolved
exchanges/hitbtc/hitbtc_websocket.go Show resolved Hide resolved
Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK!

@gloriousCode gloriousCode added the gcrc GloriousCode Review Complete label Dec 8, 2024
@gbjk gbjk force-pushed the feature/hitbtc_sub_conf branch from 1bd1ef2 to f835c80 Compare December 12, 2024 04:24
Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🖖 tACK.


All subscriptions are for spot.

Default Public Subscriptions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE 4 ME: Might be able to make this entire change dynamic across all exchanges in #1619 reduce implementation toil.

@shazbert shazbert added the szrc shazbert review complete label Dec 12, 2024
Copy link
Collaborator

@thrasher- thrasher- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK public subs, utACK private. Working well!

@thrasher- thrasher- merged commit 16e5398 into thrasher-corp:master Dec 17, 2024
5 of 11 checks passed
@gbjk gbjk deleted the feature/hitbtc_sub_conf branch December 17, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gcrc GloriousCode Review Complete medium priority review me This pull request is ready for review szrc shazbert review complete
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants