-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HitBTC: Add Subscription Configuration #1639
Conversation
3706452
to
4b6d747
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1639 +/- ##
=======================================
Coverage 36.50% 36.51%
=======================================
Files 414 414
Lines 179353 179322 -31
=======================================
- Hits 65477 65471 -6
+ Misses 106006 105965 -41
- Partials 7870 7886 +16
|
4b6d747
to
0e80320
Compare
0e80320
to
d17bfc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, tested auth and unauth. just one thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK!
1bd1ef2
to
f835c80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🖖 tACK.
|
||
All subscriptions are for spot. | ||
|
||
Default Public Subscriptions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE 4 ME: Might be able to make this entire change dynamic across all exchanges in #1619 reduce implementation toil.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK public subs, utACK private. Working well!
HitBTC
New Library Dependencies
Type of change