Subscriptions: Relax subscription validation for non-existent pairs #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1635 +/- ##
==========================================
- Coverage 36.97% 36.97% -0.01%
==========================================
Files 414 414
Lines 180449 180441 -8
==========================================
- Hits 66720 66710 -10
- Misses 105892 105893 +1
- Partials 7837 7838 +1
|
shazbert
requested changes
Sep 28, 2024
gloriousCode
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
I'm happy with the changes. Since #1480 is near the end, I'll seek clarification there and any amendments to that comment if necessary. Your work is already a part of 1480, however the if len(s.Pairs) != 0 { does not even get satisfied on CoinbasePro 🤷
tACK
thrasher-
changed the title
The subscription pairs do not need to be validated as enabled or available. The check was just belt-and-braces and didn't have a specific use-case in mind. Coinbase has a use-case for wanting to subscribe to BTC-USD when it's not enabled. Moreover, it shouldn't be our job to check this. You want a sub expanded with these pairs? Fine. Done. If it doesn't work, you can work out why
gbjk
force-pushed
the
bugfix/sub_bears_pears
branch
from
e49f7af to
a220ea7
Compare
thrasher-
changed the title
thrasher-
approved these changes
Oct 23, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subscription pairs do not need to be validated as enabled or available. The check was just belt-and-braces and didn't have a specific use-case in mind.
Coinbase has a use-case for wanting to subscribe to BTC-USD when it's not enabled.
Moreover, it shouldn't be our job to check this. You want a sub expanded with these pairs? Fine. Done. If it doesn't work, you can work out why
Type of change