Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemini: Add subscription configuration #1625

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Aug 21, 2024

Gemini

  • Add Subscription configuration
  • Upgrade test configuration

Type of change

  • New feature (non-breaking change which adds functionality)

@gbjk gbjk added the review me This pull request is ready for review label Aug 21, 2024
@gbjk gbjk self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.27%. Comparing base (17c2ef2) to head (40668a0).
Report is 74 commits behind head on master.

Files with missing lines Patch % Lines
exchanges/gemini/gemini_websocket.go 90.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1625      +/-   ##
==========================================
+ Coverage   36.37%   38.27%   +1.90%     
==========================================
  Files         422      422              
  Lines      183113   152312   -30801     
==========================================
- Hits        66602    58293    -8309     
+ Misses     108466    85972   -22494     
- Partials     8045     8047       +2     
Files with missing lines Coverage Δ
exchanges/gemini/gemini_wrapper.go 39.13% <100.00%> (+4.17%) ⬆️
exchanges/subscription/subscription.go 100.00% <ø> (ø)
exchanges/gemini/gemini_websocket.go 41.64% <90.00%> (+8.53%) ⬆️

... and 397 files with indirect coverage changes

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

exchanges/gemini/gemini_websocket.go Show resolved Hide resolved
Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! I don't know why I went to the effort to re-verify on Gemini with no auth sub support 😭

@gloriousCode gloriousCode added the gcrc GloriousCode Review Complete label Dec 5, 2024
Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add in this change:

diff --git a/exchanges/gemini/gemini_websocket.go b/exchanges/gemini/gemini_websocket.go
index a738c2856..cecf8bba1 100644
--- a/exchanges/gemini/gemini_websocket.go
+++ b/exchanges/gemini/gemini_websocket.go
@@ -169,6 +169,7 @@ func (g *Gemini) WsAuth(ctx context.Context, dialer *websocket.Dialer) error {
        if err != nil {
                return fmt.Errorf("%v Websocket connection %v error. Error %v", g.Name, endpoint, err)
        }
+       g.Websocket.Wg.Add(1)
        go g.wsFunnelConnectionData(g.Websocket.AuthConn)
        return nil
 }

To resolve #1738

@gbjk
Copy link
Collaborator Author

gbjk commented Dec 5, 2024

Could you please add in this change To resolve #1738

Fixed gbjk@487516628

@gbjk gbjk requested a review from shazbert December 5, 2024 04:31
@shazbert shazbert linked an issue Dec 5, 2024 that may be closed by this pull request
@shazbert shazbert added the bug label Dec 5, 2024
Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

Copy link
Collaborator

@thrasher- thrasher- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, thanks @shazbert for the additional fix!

@thrasher- thrasher- merged commit 66a3ff0 into thrasher-corp:master Dec 6, 2024
5 of 11 checks passed
@gbjk gbjk deleted the feature/gemini_sub_conf branch December 6, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gcrc GloriousCode Review Complete medium priority review me This pull request is ready for review szrc shazbert review complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

websocket/Gemini websocket negative waitgroup on shutdown
4 participants