Huobi: Add subscription configuration #1604

gbjk · 2024-08-06T05:20:56Z

Just adds configurable subs.

This PR does not fix auth WS usage, which appears broken due to using deprecated v1 paths.
Also doesn't seek to make subs synchronous.

Stacked Dependencies

Kucoin: Add subscription templating and various fixes #1579

Type of change

New feature (non-breaking change which adds functionality)

codecov · 2024-08-06T05:28:17Z

Codecov Report

Attention: Patch coverage is 52.27273% with 21 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (d4c4bf1) to head (6d25b82).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
exchanges/huobi/huobi_websocket.go	48.78%	18 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
+ Coverage   37.04%   37.07%   +0.02%     
==========================================
  Files         414      414              
  Lines      180305   180275      -30     
==========================================
+ Hits        66800    66832      +32     
+ Misses     105657   105578      -79     
- Partials     7848     7865      +17

Files with missing lines	Coverage Δ
exchanges/huobi/huobi_wrapper.go	`39.69% <100.00%> (+0.02%)`	⬆️
exchanges/kraken/kraken_websocket.go	`55.60% <100.00%> (ø)`
exchanges/subscription/subscription.go	`100.00% <ø> (ø)`
exchanges/huobi/huobi_websocket.go	`36.51% <48.78%> (+10.20%)`	⬆️

... and 11 files with indirect coverage changes

shazbert

Good stuff, minor potential nit

exchanges/huobi/huobi_websocket.go

shazbert

LGTM.

gloriousCode

Also doesn't seek to make subs synchronous

Why not? Huobi has id support which would allow for SendMessageReceiveResponse

exchanges/subscription/list.go

exchanges/huobi/huobi_websocket.go

gbjk · 2024-10-10T07:49:01Z

Also doesn't seek to make subs synchronous

Why not? Huobi has id support which would allow for SendMessageReceiveResponse

It's just not the focus of this PR. I have a list of things to fix on Huobi after this is merged, and synchronous Subscribe is one of them.
The PRs that touch everything at once are painful to review, painful to merge, and conflict often.
So I'm trying to work with more agility, limited blast zones, and iterative improvements. 🙂

That said: I can sniff making it synchronous now it it's a dealbreaker for this to be merged.

gloriousCode

Tested OB levels ✅
One more thing

exchanges/huobi/huobi_test.go

gbjk · 2024-11-04T02:54:09Z

That said: I can sniff making it synchronous now it it's a dealbreaker for this to be merged.

This became too much for this PR. It just snowballed endlessly. I'm nearly done, but it should not get stacked on top of this.

So let's review this in the context of the title only.

gloriousCode

Thanks for making those changes, one petty request

exchanges/huobi/huobi_test.go

exchanges/huobi/huobi_websocket.go

gloriousCode

tACK

thrasher-

All looks good, only minor things with the known caveat of disabled auth subs

exchanges/huobi/huobi_websocket.go

exchanges/huobi/huobi_test.go

Rename ErrPrivateChannelName to ErrUseConstChannelName

thrasher-

Thanks for making those changes!

shazbert

Good stuff tACK!

gbjk added the nomerge requires dependency This pull request is dependent on another, so it can't be merged until the dependent one is merged label Aug 6, 2024

gbjk self-assigned this Aug 6, 2024

gbjk force-pushed the feature/huobi_sub_conf branch 2 times, most recently from b4f8fa0 to 315c634 Compare August 13, 2024 09:04

gbjk added review me This pull request is ready for review and removed nomerge requires dependency This pull request is dependent on another, so it can't be merged until the dependent one is merged labels Aug 13, 2024

gbjk requested review from shazbert, gloriousCode and thrasher- and removed request for shazbert and gloriousCode August 13, 2024 09:13

shazbert requested changes Aug 27, 2024

View reviewed changes

exchanges/huobi/huobi_websocket.go Outdated Show resolved Hide resolved

gbjk requested a review from shazbert August 28, 2024 03:55

shazbert approved these changes Aug 28, 2024

View reviewed changes

shazbert added the rebase/merge of master required label Sep 28, 2024

gloriousCode requested changes Oct 10, 2024

View reviewed changes

exchanges/subscription/list.go Outdated Show resolved Hide resolved

exchanges/huobi/huobi_websocket.go Show resolved Hide resolved

gbjk requested a review from gloriousCode October 10, 2024 08:00

gloriousCode requested changes Oct 14, 2024

View reviewed changes

exchanges/huobi/huobi_test.go Show resolved Hide resolved

gbjk force-pushed the feature/huobi_sub_conf branch from d789658 to fedd1ab Compare October 17, 2024 11:04

gbjk added reconstructing Based on PR feedback, this is currently being reworked and is not to be merged and removed rebase/merge of master required review me This pull request is ready for review labels Oct 18, 2024

gbjk force-pushed the feature/huobi_sub_conf branch 3 times, most recently from 8c132cd to bae9e4d Compare October 21, 2024 03:39

thrasher- added the medium priority label Oct 21, 2024

gbjk force-pushed the feature/huobi_sub_conf branch 2 times, most recently from 2a8075d to 58a8c92 Compare October 28, 2024 08:04

gbjk force-pushed the feature/huobi_sub_conf branch 2 times, most recently from c0c226c to 86b8b4c Compare November 4, 2024 02:50

gbjk requested a review from gloriousCode November 4, 2024 02:54

gbjk added review me This pull request is ready for review and removed reconstructing Based on PR feedback, this is currently being reworked and is not to be merged labels Nov 4, 2024

gloriousCode requested changes Nov 4, 2024

View reviewed changes

exchanges/huobi/huobi_test.go Show resolved Hide resolved

exchanges/huobi/huobi_websocket.go Outdated Show resolved Hide resolved

gbjk requested a review from gloriousCode November 5, 2024 07:18

gbjk mentioned this pull request Nov 6, 2024

Huobi: V2 subscription support #1703

Open

5 tasks

gloriousCode requested a review from shazbert November 8, 2024 00:04

gloriousCode approved these changes Nov 8, 2024

View reviewed changes

gbjk added the rebase/merge of master required label Nov 11, 2024

Huobi: Update test config format

8f882b9

gbjk force-pushed the feature/huobi_sub_conf branch from 2ba4b27 to 9c726f4 Compare November 11, 2024 01:11

gbjk removed the rebase/merge of master required label Nov 11, 2024

thrasher- requested changes Nov 11, 2024

View reviewed changes

exchanges/huobi/huobi_websocket.go Show resolved Hide resolved

exchanges/huobi/huobi_websocket.go Show resolved Hide resolved

exchanges/huobi/huobi_test.go Outdated Show resolved Hide resolved

gbjk requested a review from thrasher- November 11, 2024 01:50

gbjk added 5 commits November 11, 2024 08:58

Huobi: Add subscription configuration

92b69ac

Huobi: Add subscription documentation

4bf5088

Huobi: Clarify OB sub Levels usage

cc98dec

Huobi: Enable websocket for tests

9e98c65

Subscriptions: Rename ErrPrivateChannelName

6d25b82

Rename ErrPrivateChannelName to ErrUseConstChannelName

gbjk force-pushed the feature/huobi_sub_conf branch from 8bbe191 to 6d25b82 Compare November 11, 2024 01:59

thrasher- approved these changes Nov 11, 2024

View reviewed changes

thrasher- changed the title ~~Huobi: Add Subscription configuration~~ Huobi: Add subscription configuration Nov 11, 2024

shazbert approved these changes Nov 11, 2024

View reviewed changes

thrasher- merged commit a2a7fed into thrasher-corp:master Nov 11, 2024
8 of 13 checks passed

gbjk deleted the feature/huobi_sub_conf branch November 11, 2024 03:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Huobi: Add subscription configuration #1604

Huobi: Add subscription configuration #1604

gbjk commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 6, 2024 •

edited

Loading

shazbert left a comment

shazbert left a comment

gloriousCode left a comment

gbjk commented Oct 10, 2024

gloriousCode left a comment

gbjk commented Nov 4, 2024

gloriousCode left a comment

gloriousCode left a comment

thrasher- left a comment

thrasher- left a comment

shazbert left a comment

Huobi: Add subscription configuration #1604

Huobi: Add subscription configuration #1604

Conversation

gbjk commented Aug 6, 2024 • edited Loading

Stacked Dependencies

Type of change

codecov bot commented Aug 6, 2024 • edited Loading

Codecov Report

shazbert left a comment

Choose a reason for hiding this comment

shazbert left a comment

Choose a reason for hiding this comment

gloriousCode left a comment

Choose a reason for hiding this comment

gbjk commented Oct 10, 2024

gloriousCode left a comment

Choose a reason for hiding this comment

gbjk commented Nov 4, 2024

gloriousCode left a comment

Choose a reason for hiding this comment

gloriousCode left a comment

Choose a reason for hiding this comment

thrasher- left a comment

Choose a reason for hiding this comment

thrasher- left a comment

Choose a reason for hiding this comment

shazbert left a comment

Choose a reason for hiding this comment

gbjk commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 6, 2024 •

edited

Loading