Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currency/exchanges: Add bespoke exchange translator and pair matching helper #1556

Merged
merged 18 commits into from
Aug 16, 2024

thrasher: nits

59d6192
Select commit
Loading
Failed to load commit list.
Merged

currency/exchanges: Add bespoke exchange translator and pair matching helper #1556

thrasher: nits
59d6192
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 16, 2024 in 0s

36.36% (+0.06%) compared to 90fee94

View this Pull Request on Codecov

36.36% (+0.06%) compared to 90fee94

Details

Codecov Report

Attention: Patch coverage is 92.40506% with 6 lines in your changes missing coverage. Please review.

Project coverage is 36.36%. Comparing base (90fee94) to head (59d6192).
Report is 18 commits behind head on master.

Files Patch % Lines
currency/translation.go 91.42% 2 Missing and 1 partial ⚠️
exchanges/okx/okx_wrapper.go 62.50% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   36.29%   36.36%   +0.06%     
==========================================
  Files         420      422       +2     
  Lines      183150   183117      -33     
==========================================
+ Hits        66482    66592     +110     
+ Misses     108605   108477     -128     
+ Partials     8063     8048      -15     
Files Coverage Δ
currency/code_types.go 0.00% <ø> (ø)
exchanges/bybit/bybit_wrapper.go 43.20% <100.00%> (+2.54%) ⬆️
exchanges/gateio/gateio_wrapper.go 39.68% <100.00%> (+0.09%) ⬆️
exchanges/kucoin/kucoin_wrapper.go 34.79% <100.00%> (-0.23%) ⬇️
exchanges/okx/okx.go 20.10% <100.00%> (+0.08%) ⬆️
exchanges/okx/okx_types.go 40.44% <ø> (ø)
currency/translation.go 92.68% <91.42%> (-7.32%) ⬇️
exchanges/okx/okx_wrapper.go 30.89% <62.50%> (+0.02%) ⬆️

... and 43 files with indirect coverage changes