Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exchanges: Update Binance #1546

Open
wants to merge 159 commits into
base: master
Choose a base branch
from
Open

Conversation

samuael
Copy link
Collaborator

@samuael samuael commented May 19, 2024

PR Description

This PR updates the Binance exchange by addressing WebSocket enhancements, adding or updating endpoints, and implementing unit tests for each endpoint, along with mock records. Additionally, it introduces new endpoints under European Options and Portfolio Margin and extends WebSocket streaming support for futures and spot endpoints. The new WebSocket streaming functionality supports USDT-margined and coin-margined futures assets, establishing connections and managing incoming stream data separately. Furthermore, this PR adds a group of endpoints that utilize endpoint calls through the WebSocket stream, building on the previous Binance WebSocket update.

Type of change

Please delete options that are not relevant and add an x in [] as the item is complete.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also, consider improving test coverage whilst working on a certain feature or package.

  • go test ./... -race
  • golangci-lint run
  • Test X

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on GitHub Actions with my changes
  • Any dependent changes have been merged and published in downstream modules

@shazbert shazbert added the tests require fixing This is to denote that the PR has some tests that require fixing before the review can be completed label Sep 28, 2024
@shazbert shazbert removed rebase/merge of master required tests require fixing This is to denote that the PR has some tests that require fixing before the review can be completed labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants