-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa: Enforce JSON linter for GCT configs #1526
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
+ Coverage 36.02% 36.03% +0.01%
==========================================
Files 411 411
Lines 176891 176914 +23
==========================================
+ Hits 63726 63757 +31
+ Misses 105384 105369 -15
- Partials 7781 7788 +7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tickity Tack.
|
||
- name: Check configs JSON format | ||
run: | | ||
files=("config_example.json" "testdata/configtest.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it was made to be extensible but this PR only targets our mainly touched configs for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK!
make lint_configs
Checking if jq is installed...
Processing config_example.json...
jq: parse error: Invalid numeric literal at line 16, column 0
jq processing failed on *.json
make: *** [lint_configs] Error 1
make lint_configs
Checking if jq is installed...
Processing config_example.json...
Processing testdata/configtest.json...
Confirmed that it works 🌞 Emoji's inside yml files is approved too
…ONY and rid excess newlines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retACK! Increase in actual human friendliness detected
make lint_configs
-n Checking if jq is installed...
OK
-n Processing config_example.json...
OK
-n Processing testdata/configtest.json...
OK
make lint_configs
-n Checking if jq is installed...
OK
-n Processing config_example.json...
OK
-n Processing testdata/configtest.json...
jq: parse error: Invalid numeric literal at line 462, column 0
FAILED
make: *** [lint_configs] Error 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ch tack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make lint_configs
Checking if jq is installed... OK
Processing config_example.json... OK
Processing testdata/configtest.json... OK
make lint_configs
Checking if jq is installed... OK
Processing config_example.json... OK
Processing testdata/configtest.json... jq: parse error: Invalid numeric literal at line 462, column 0
FAILED
make: *** [lint_configs] Error 1
Now with less -n
PR Description
Adds a new GHA and Makefile utility command to enforce JSON format standards for our configs using jq. Also sorts the exchanges by name for now rather than the whole file for starters.
Type of change
How has this been tested
make lint_configs
and manual breaking to make sure the diff wigs outChecklist