-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/build: Update Go version, linters and fix minor issues #1473
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1473 +/- ##
==========================================
- Coverage 44.01% 37.78% -6.23%
==========================================
Files 363 411 +48
Lines 143949 147817 +3868
==========================================
- Hits 63353 55856 -7497
- Misses 72973 84185 +11212
- Partials 7623 7776 +153
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, nice. Something I noticed if you want to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint good
build good
updates good
I mistakenly was on golangci-lint v1.56.1 and made a diff for it, but oh well 😭
tACK!
Looks like they brought out 1.56.1 a day after this was done. Bumped it and applied the diff 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pedantic sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Nice ch ACK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Excellent updates
PR Description
Bumps Go to version 1.22
Bumps golangci-lint to v1.56.1
Linter changes:
Type of change
How has this been tested
Checklist