Okx: Fix GetInsuranceFundInformation "" resp #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When amount is "" this was erroring
Simple jq formatting of configtest git diff -w or github ignore whitespaces should show no changes. Any conflicts, just accept --ours and reformat it. Or not :o)
shazbert
approved these changes
Nov 26, 2023
shazbert
added
review me
thrasher-
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When amt is "" GetInsuranceFundInformation was erroring.
amt is documented to return empty when type is
regular_updateAdded some more test coverage, impinged by the fields not actually being populated for currency.
Fixes Trello 211
Also quickly formats configtest.json with jq. Because this is a small and quick PR to get such a thing done in.
git diff -w or github ignore whitespaces should show no changes.
Any conflicts, just accept --ours and reformat it. Or not.
Type of change
How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.