Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitfinex: Refactor wsUpdate handling #1317

Merged
merged 31 commits into from
Sep 1, 2023
Merged

Bitfinex: Refactor wsUpdate handling #1317

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
83c6ea7
Bitfinex: Fix cancel/update order WS ack not seen
gbjk Aug 1, 2023
42b43f5
Bitfinex: Fix ws Unsubscribe and Resubscribe
gbjk Aug 6, 2023
f13e3d6
Bitfinex: Fix ws Trades Fees on te
gbjk Aug 8, 2023
9b0296e
Bitfinex: Fix error on ws auth ok
gbjk Aug 10, 2023
35ffcd1
Merge branch 'bugfix/bfx_ws_cancels' into bugfix/bfx_ws_refactor
gbjk Aug 10, 2023
cb685cc
Merge branch 'bugfix/bfx_unsub' into bugfix/bfx_ws_refactor
gbjk Aug 10, 2023
f55f64f
Merge branch 'bugfix/bfx_tu_fees' into bugfix/bfx_ws_refactor
gbjk Aug 10, 2023
37fceb3
Bitfinex: Refactor wsUpdate handling
gbjk Aug 10, 2023
338249f
Binfinex: Fix linter issue on chanId casing
gbjk Aug 10, 2023
e1e9c36
Bitfinex: Fix linter outdent complaint
gbjk Aug 10, 2023
46f0d40
Bitfinex: Fix linter issues on test
gbjk Aug 10, 2023
38ece78
Bitfinex: Fix TestWsTradingPairSnapshot chan lookup
gbjk Aug 10, 2023
fdb33cd
Bitfinex: Remove unnecessary WsAddSubs in test
gbjk Aug 16, 2023
17c5735
Bitfinex: Fix TestWsSubscribedResponse chan
gbjk Aug 16, 2023
194ec1a
Bitfinex: Throw a specific error for bad event
gbjk Aug 16, 2023
f002f56
Bitfinex: WS Type assertions for positionSnapshots
gbjk Aug 16, 2023
d556b02
Bitfinex: tradeUpdate type assertion
gbjk Aug 16, 2023
9219d3f
Bitfinex: Reinstate default subscriptions
gbjk Aug 16, 2023
8d0f247
Bitfinex: Assert chan assetType is the same
gbjk Aug 16, 2023
648730e
Bitfinex: Lowercase error string
gbjk Aug 16, 2023
631a933
Bitfinex: Refactor WS eventType/chanId handling
gbjk Aug 21, 2023
5ed861c
Bitfinex: Fix linter issues
gbjk Aug 22, 2023
234112e
Bitfinex: Fix delimiter for pairs with more than 6 chars
gbjk Aug 28, 2023
3fe9b8e
Bitfinex: Fix WS handling of subscribed symbols
gbjk Aug 28, 2023
edf7cbb
Bitfinex: Placate the linter
gbjk Aug 28, 2023
29adba7
Bitfinex: Disable margin assets for WS
gbjk Aug 29, 2023
a94cf13
Bitfinex: Fix parsing of 4 part funding keys
gbjk Aug 30, 2023
49e5d98
Bitfinex: Linter fixes
gbjk Aug 30, 2023
b93a5e3
Bitfinex: Remove key parsing from assetPairFromSymbol
gbjk Aug 30, 2023
d38d0c2
Bitfinex: Use native error wrapping
gbjk Sep 1, 2023
7e089a7
Bitfinex: Skip disabled assets in default ws subs
gbjk Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exchanges/bitfinex/bitfinex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/order"
"github.com/thrasher-corp/gocryptotrader/exchanges/request"
"github.com/thrasher-corp/gocryptotrader/exchanges/stream"
"github.com/thrasher-corp/gocryptotrader/portfolio/withdraw"
)

Expand Down Expand Up @@ -105,7 +106,7 @@ const (
// Bitfinex is the overarching type across the bitfinex package
type Bitfinex struct {
exchange.Base
WebsocketSubdChannels map[int]WebsocketChanInfo
WebsocketSubdChannels map[int]*stream.ChannelSubscription
}

// GetPlatformStatus returns the Bifinex platform status
Expand Down
Loading