Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitfinex: Fix ws Trades Fees on te #1310

Closed
wants to merge 1 commit into from

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Aug 8, 2023

The ws channel for authenticated Trades sends two types of update:

  • te, Trade Executed
  • tu, Trade Execution Update

Only the second one contains fee information.
See the docs

This commit fixes:
exchange Bitfinex websocket error - unable to type assert trade fee
after an executed market trade on the te update

Side-note: I was tempted to type eventType but I've deliberately avoided yaking too much on this.

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested

  • go test ./... -race
  • golangci-lint run

The ws channel for authenticated Trades sends two types of update:
* te, Trade Executed
* tu, Trade Execution Update

Only the second one contains fee information.
[See the docs](https://docs.bitfinex.com/reference/ws-auth-trades)

This commit fixes:
`exchange Bitfinex websocket error - unable to type assert trade fee`
after an executed market trade on the te update
@thrasher- thrasher- added the review me This pull request is ready for review label Aug 10, 2023
@thrasher- thrasher- requested a review from a team August 10, 2023 00:08
@gbjk gbjk mentioned this pull request Aug 10, 2023
3 tasks
@gbjk
Copy link
Collaborator Author

gbjk commented Sep 2, 2023

Merged as part of #1317

@gbjk gbjk closed this Sep 2, 2023
@gbjk gbjk deleted the bugfix/bfx_tu_fees branch September 2, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants