Bitfinex: Fix ws Unsubscribe and Resubscribe #1302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsubscribe needed to use the channel id. Resubscribe needs to have the original subscription params.
3 tasks
|
This PR introduces an error output into the tests right now: |
|
Okay, no. There's no reason to make the refactor part of this PR. Backing up. |
This fixes: `Bitfinex Could not find an existing channel subscription: account Pair: ChannelID: 0` It's not clear from history why we'd want to store a reference to the ubiquitous 0 channel like this, but it's definitely wrong, and anything that attempts to get channel information about 0 chan needs to be fixed anyway.
|
Just fixed the 0 chan sub, and that's it. Will push refactor separately |
This was a test artefact only, but better to be clean
3 tasks
This is a short term fix for handling the auth chan (0 chan) not being in subs. It's refactored much better in thrasher-corp#1317
|
Merged as part of #1317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsubscribe needed to use the channel id.
Resubscribe needs to have the original subscription params.
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested