Bitfinex: Improve websocket type assertion checks for order processing #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
shazbert
requested changes
Aug 11, 2023
gbjk
force-pushed
the
bugfix/bfx_ws_cancels
branch
from
5c1398e to
a03e482
Compare
|
Strange as this might seem, this branch had 1 nit from @shazbert which didn't make it into the main refactor. Rebased on master already |
thrasher-
changed the title
thrasher-
approved these changes
Sep 7, 2023
thrasher-
reviewed
Sep 7, 2023
| @@ -916,7 +916,9 @@ func (b *Bitfinex) handleWSNotification(d []interface{}, respRaw []byte) error { | |||
| } | |||
| case strings.Contains(channelName, wsOrderNewRequest): | |||
| if data[2] != nil { | |||
| if cid, ok := data[2].(float64); ok && cid > 0 { | |||
| if cid, ok := data[2].(float64); !ok { | |||
| return common.GetTypeAssertError("float64", data[2]) | |||
There was a problem hiding this comment.
Suggested change
| return common.GetTypeAssertError("float64", data[2]) | |
| return common.GetTypeAssertError("float64", data[2], "wsOrderNewRequest cid") |
gloriousCode
approved these changes
Sep 7, 2023
shazbert
pushed a commit
to shazbert/gocryptotrader
that referenced
this pull request
Nov 10, 2023
thrasher-corp#1292) * Bitfinex: Error if ws data id/cid is not a float64 * Bitfinex: Add annotation to WS id/cid assest errs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1288
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested