linters: Bump golangci-lint version to v1.52.2 and fix issues

[samuael]

This pull request contains several fixes to the gocryptotrader codebase, including a fix for a linter issue, suppressing some linter issues by adding a linter directive, removing unnecessary linter directives, and changing some variable names to constants.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as the item is complete.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How has this been tested

• go test ./... -race
• golangci-lint run
• Test X

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally and on Github Actions/AppVeyor with my changes
• Any dependent changes have been merged and published in downstream modules

[gloriousCode]

Always nice to see you get more familiar with our codebase 🎉
You'll just need to be more specific with your nolints

[shazbert]

Thanks for the changes! Are you getting these linter issues from the most recent version? If so, can you please bump all versions for GitHub actions like linter.yml and else ware?

[samuael]

Yes, I found these issues after upgrading my linter. golangci-lint v1.52.2 with go1.20.2.

Okay sir I will update the .github/workflows/linter.yml file with my next commit. After few minutes

[shazbert]

Appveyor is complaining :

Could you please bump the versions for golanci-lint across the code base.

[shazbert]

This is lovely. Thanks! 👍

[gloriousCode]

tACK! Thanks for making those changes

[thrasher-]

Nice work @samuael !

[samuael]

Thank you, sir.
and I want to give a big Thanks to @shazbert and @gloriousCode for your help on this PR.