exchanges: Add V2 Crypto.com exchange support #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazbert
requested changes
Jan 30, 2023
Comment on lines
52
to
54
| publicGetValuations = "public/get-valuations" // skipped | ||
| publicGetExpiredSettlementPrice = "public/get-expired-settlement-price" // skipped | ||
| publicGetInsurance = "public/get-insurance" // skipped |
| return nil, currency.ErrCurrencyPairEmpty | ||
| } | ||
| var notional float64 | ||
| switch s.Type { |
There was a problem hiding this comment.
NOTE: Test for when both s.Amount and notional are sent.
shazbert
added
reconstructing
shazbert
added
review me
shazbert
requested changes
Feb 6, 2023
| @@ -320,6 +300,85 @@ type CreateOrderParam struct { | |||
| TriggerPrice float64 `json:"trigger_price"` | |||
| } | |||
|
|
|||
| func (arg *CreateOrderParam) getCreateParamMap() (map[string]interface{}, error) { | |||
There was a problem hiding this comment.
This needs full test coverage and utilizing if !errors.Is(err, errGlobalError) { }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pull request adds a code implementation for version 2 of the Crypto.com exchange. The implementation supports REST and web-socket functionalities. All the REST, WebSocket endpoints, and wrapper functions are tested. My code adheres to the GCT style standards used by other exchanges.
Fixed some errors with the help of linter(golangci-lint), and unit tests. REST and WebSocket endpoint methods that have no support from the GCT wrapper are also implemented for future use.
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
xin[]as the item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also, consider improving test coverage whilst working on a certain feature or package.
Checklist