Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitfinex: Fix WS Trade stream erroring #1746

Open
gbjk opened this issue Dec 11, 2024 · 0 comments · May be fixed by #1754
Open

Bitfinex: Fix WS Trade stream erroring #1746

gbjk opened this issue Dec 11, 2024 · 0 comments · May be fixed by #1754
Assignees
Labels

Comments

@gbjk
Copy link
Collaborator

gbjk commented Dec 11, 2024

The public trade stream in bitfinex websocket now contains a sequence field final field in the snapshot update.

This triggers an error:
exchange Bitfinex websocket error - unhandled WS trade update event:
( which goes to the DataHandler )

Our test avoids seeing this by mocking the input to the trade stream in the old state.

Probably consider #1323 at the same time

@gbjk gbjk added the bug label Dec 11, 2024
@gbjk gbjk self-assigned this Dec 11, 2024
@gbjk gbjk moved this to In progress in GoCryptoTrader Kanban Dec 11, 2024
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Dec 18, 2024
* Add handling for funding trades

Fixes thrasher-corp#1746
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Dec 18, 2024
* Add handling for funding trades

Fixes thrasher-corp#1746
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Dec 18, 2024
* Add handling for funding trades

Fixes thrasher-corp#1746
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Dec 18, 2024
* Add handling for funding trades

Fixes thrasher-corp#1746
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Dec 18, 2024
* Add handling for funding trades

Fixes thrasher-corp#1746
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Dec 18, 2024
* Add handling for funding trades

Fixes thrasher-corp#1746
@gbjk gbjk linked a pull request Dec 18, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

1 participant