-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for sending to multiple recipients via sendmail #797
Conversation
Does this also work for the smtp method? That field should probably work the same for both mechanisms. This PR is missing documentation (although the doc doesn't mention sendmail at all), and an entry in the changelog. |
Yes, it already works for SMTP
Done. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a to in the example would make sense, but otherwise, it looks good to me.
FYI (in case you didn't know already), I'm not a maintainer, just helping out, so you'll need a maintainer to actually do the approve/merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, two small comments.
Co-authored-by: Thomas Perl <[email protected]>
Co-authored-by: Thomas Perl <[email protected]>
Thanks for the review, applied the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
thank you!
|
if the
to
config contains multiple emails such as[email protected],[email protected]