Improves HTML diff table format for long line lengths. #793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If very long lines are present in an HTML diff report, the HTML table layout can become less than ideal. One half of the diff can be very wide and the entire table can be wider than the screen.
The built-in
difflib
output includes anowrap
HTML attribute on the table cells containing diff text lines. However, wrapping diff lines is both useful and typical. See the below GitHub diff screenshot for an example:This PR uses CSS to override that
nowrap
attribute and allow for sane line wrapping while also ensuring the left and right halves of the diff table are equal width.Current rendering:
Table is too wide for the viewport, left side is much narrower than the right.
Proposed rendering:
Table fits within the viewport, both sides are equal width, long diff lines are wrapped without adversely affecting line numbering.