New option: ignore_incomplete_reads #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
requested changes
Feb 12, 2024
wfrisch
force-pushed
the
feat/ignore_incomplete_reads
branch
from
d8a432a
to
37ba3dd
Compare
Sometimes web servers return incomplete responses, triggering an `InvalidChunkLength` exception in urlwatch. Enable this job option to ignore these errors. thp#725
wfrisch
force-pushed
the
feat/ignore_incomplete_reads
branch
from
37ba3dd
to
593f052
Compare
Thanks for the review. It should be OK now. |
wfrisch
force-pushed
the
feat/ignore_incomplete_reads
branch
from
593f052
to
b6f7cff
Compare
wfrisch
force-pushed
the
feat/ignore_incomplete_reads
branch
from
b6f7cff
to
20db781
Compare
|
For completeness' sake, here's a deliberately broken web server that emulates this error class: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #725