Applies larger line spacing only to diff tables. #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the
<body>line-height adjustment introduced in #730 and instead applies it to<table>elements so that the increased line-height only applies to HTML table diffs. This higher line height was originally introduced to emulate the GitHub web diff rendering.With this change, text-based diffs will go back to regular line heights. See #774
As a visual, here are the results of
diff: tableanddiff: unifiedfor thehtmlreporter. Note that these were rendered in Chrome as different email clients can render the HTML differently (e.g. web Gmail ignores the line-height anyway)Table (note 1.5 line height)
Unified (note 1.0 line height)