Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TI-626 Routing Issue with Dashboard Bug #240

Conversation

madison-kneller-ti
Copy link
Contributor

@madison-kneller-ti madison-kneller-ti commented Aug 26, 2024

Resolves TI-626

When replacing the dashboard component, on login, the user would be led to the native dashboard (/learn/) instead of (/learn/dashboard). This fix adds "dashboard" to the end of the window.location.href during login to lead the user to the correct dashboard.

@rjschill87
Copy link
Contributor

@madison-kneller-ti - can you expand a bit on how sending the user to /learn/dashboard instead of /learn resolves the issue with /learn hanging?

The reason it was set to send users to /learn was to replicate native functionality where we'd send students to their dashboard and admins to the manager UI. This change could possibly resolve the issue for users using a custom sign in page - but devs can add a custom dashboard and still use the native sign in, which will still have the "problem" path of sending users to /learn after sign in.

@madison-kneller-ti
Copy link
Contributor Author

Closed this PR in favor of a solution in the ti repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants