Configures action mailer asset host #853

delphaber · 2017-07-10T07:32:22Z

No description provided.

houndci-bot · 2017-07-10T07:32:28Z

spec/features/new_project_spec.rb

@@ -155,6 +155,12 @@
      to match(/^ +config.action_mailer.delivery_method = :file$/)
  end

+  it "sets action mailer default host and asset host" do
+    expect(production_config).to match(
+      /config\.action_mailer\.asset_host = { host: ENV\.fetch\("ASSET_HOST", ENV\.fetch\("APPLICATION_HOST"\)\) }/


Put a comma after the last parameter of a multiline method call.
Line is too long. [114/80]

houndci-bot · 2017-07-10T07:32:28Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production", %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [102/80]

houndci-bot · 2017-07-10T07:32:29Z

spec/features/new_project_spec.rb

@@ -155,6 +155,12 @@
      to match(/^ +config.action_mailer.delivery_method = :file$/)
  end

+  it "sets action mailer default host and asset host" do
+    expect(production_config).to match(
+      /config\.action_mailer\.asset_host = { host: ENV\.fetch\("ASSET_HOST", ENV\.fetch\("APPLICATION_HOST"\)\) }/


Put a comma after the last parameter of a multiline method call.
Line is too long. [114/80]

houndci-bot · 2017-07-10T07:32:29Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production", %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [102/80]

houndci-bot · 2017-07-10T07:32:29Z

spec/features/new_project_spec.rb

@@ -155,6 +155,12 @@
      to match(/^ +config.action_mailer.delivery_method = :file$/)
  end

+  it "sets action mailer default host and asset host" do
+    expect(production_config).to match(
+      /config\.action_mailer\.asset_host = { host: ENV\.fetch\("ASSET_HOST", ENV\.fetch\("APPLICATION_HOST"\)\) }/


Put a comma after the last parameter of a multiline method call.
Line is too long. [114/80]

houndci-bot · 2017-07-10T07:32:29Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production", %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [102/80]

nickcharlton · 2017-07-10T12:40:23Z

Looks good! Let's tidy up those long lines and then I'll merge.

delphaber · 2017-07-25T09:54:35Z

I'll try to do it before vacation!

houndci-bot · 2017-07-30T13:21:10Z

spec/features/new_project_spec.rb

@@ -155,6 +155,12 @@
      to match(/^ +config.action_mailer.delivery_method = :file$/)
  end

+  it "sets action mailer default host and asset host" do
+    config_key = 'config\.action_mailer\.asset_host'
+    config_value = '{ host: ENV\.fetch\("ASSET_HOST", ENV\.fetch\("APPLICATION_HOST"\)\) }'


Line is too long. [91/80]

houndci-bot · 2017-07-30T13:21:11Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production",
+                               %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [88/80]

houndci-bot · 2017-07-30T13:21:11Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production",
+                               %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [88/80]

houndci-bot · 2017-07-30T13:21:11Z

spec/features/new_project_spec.rb

@@ -155,6 +155,12 @@
      to match(/^ +config.action_mailer.delivery_method = :file$/)
  end

+  it "sets action mailer default host and asset host" do
+    config_key = 'config\.action_mailer\.asset_host'
+    config_value = '{ host: ENV\.fetch\("ASSET_HOST", ENV\.fetch\("APPLICATION_HOST"\)\) }'


Line is too long. [91/80]

houndci-bot · 2017-07-30T13:21:11Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production",
+                               %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [88/80]

houndci-bot · 2017-07-30T13:21:11Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production",
+                               %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [88/80]

houndci-bot · 2017-07-30T13:21:11Z

spec/features/new_project_spec.rb

@@ -155,6 +155,12 @@
      to match(/^ +config.action_mailer.delivery_method = :file$/)
  end

+  it "sets action mailer default host and asset host" do
+    config_key = 'config\.action_mailer\.asset_host'
+    config_value = '{ host: ENV\.fetch\("ASSET_HOST", ENV\.fetch\("APPLICATION_HOST"\)\) }'


Line is too long. [91/80]

houndci-bot · 2017-07-30T13:21:11Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production",
+                               %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [88/80]

houndci-bot · 2017-07-30T13:21:11Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production",
+                               %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [88/80]

houndci-bot · 2017-07-30T13:21:11Z

spec/features/new_project_spec.rb

@@ -155,6 +155,12 @@
      to match(/^ +config.action_mailer.delivery_method = :file$/)
  end

+  it "sets action mailer default host and asset host" do
+    config_key = 'config\.action_mailer\.asset_host'
+    config_value = '{ host: ENV\.fetch\("ASSET_HOST", ENV\.fetch\("APPLICATION_HOST"\)\) }'


Line is too long. [91/80]

houndci-bot · 2017-07-30T13:21:11Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production",
+                               %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [88/80]

houndci-bot · 2017-07-30T13:21:11Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host "production",
+                               %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Line is too long. [88/80]

houndci-bot · 2017-07-30T13:22:18Z

lib/suspenders/app_builder.rb

      action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
+      action_mailer_asset_host(
+        "production",
+        %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}


Put a comma after the last parameter of a multiline method call.

delphaber · 2017-07-30T13:37:07Z

Fixed hound warnings. Woof!

nickcharlton · 2017-07-30T13:53:24Z

Looks good! Going to merge.

houndci-bot reviewed Jul 10, 2017

View reviewed changes

delphaber mentioned this pull request Jul 10, 2017

Set ActionMailer's asset_host #843

Closed

delphaber force-pushed the action_mail_asset_host branch from c07a2ca to 4149592 Compare July 30, 2017 13:21

houndci-bot reviewed Jul 30, 2017

View reviewed changes

delphaber force-pushed the action_mail_asset_host branch from 4149592 to 37e0d43 Compare July 30, 2017 13:22

houndci-bot reviewed Jul 30, 2017

View reviewed changes

Configures action mailer asset host

d1e2c49

delphaber force-pushed the action_mail_asset_host branch from 37e0d43 to d1e2c49 Compare July 30, 2017 13:23

nickcharlton merged commit c2f02ae into thoughtbot:master Jul 30, 2017

delphaber mentioned this pull request Aug 4, 2017

Fix for action mailer asset_host: it should be a string, not an hash #858

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configures action mailer asset host #853

Configures action mailer asset host #853

delphaber commented Jul 10, 2017

houndci-bot Jul 10, 2017

houndci-bot Jul 10, 2017

houndci-bot Jul 10, 2017

houndci-bot Jul 10, 2017

houndci-bot Jul 10, 2017

houndci-bot Jul 10, 2017

nickcharlton commented Jul 10, 2017

delphaber commented Jul 25, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

houndci-bot Jul 30, 2017

delphaber commented Jul 30, 2017

nickcharlton commented Jul 30, 2017

		action_mailer_host "production", %{ENV.fetch("APPLICATION_HOST")}
		action_mailer_asset_host "production", %{ENV.fetch("ASSET_HOST", ENV.fetch("APPLICATION_HOST"))}

Configures action mailer asset host #853

Configures action mailer asset host #853

Conversation

delphaber commented Jul 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickcharlton commented Jul 10, 2017

delphaber commented Jul 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

delphaber commented Jul 30, 2017

nickcharlton commented Jul 30, 2017