Update Rails to 5.1 #847
Update Rails to 5.1 #847
Conversation
spec/features/new_project_spec.rb
Outdated
| @@ -229,7 +229,7 @@ | |||
|
|
|||
| expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging") | |||
| expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1") | |||
| expect(bin_setup).to include("heroku run rake db:migrate --exit-code --app $APP_NAME") | |||
| expect(bin_setup).to include("heroku run rails db:migrate --exit-code --app $APP_NAME") | |||
spec/features/new_project_spec.rb
Outdated
| @@ -32,7 +32,7 @@ | |||
| it "includes the bundle:audit task" do | |||
| Dir.chdir(project_path) do | |||
| Bundler.with_clean_env do | |||
| expect(`rake -T`).to include('rake bundle:audit') | |||
| expect(`rails -T`).to include('rails bundle:audit') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| desc: "Skip system test files" | ||
|
|
||
| class_option :skip_turbolinks, type: :boolean, default: true, | ||
| desc: "Skip turbolinks gem" |
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
| @@ -29,6 +29,12 @@ class AppGenerator < Rails::Generators::AppGenerator | |||
| class_option :skip_test, type: :boolean, default: true, | |||
| desc: "Skip Test Unit" | |||
|
|
|||
| class_option :skip_system_test, type: :boolean, default: true, | |||
| desc: "Skip system test files" | |||
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
lib/suspenders/app_builder.rb
Outdated
| @@ -227,7 +219,7 @@ def use_postgres_config_template | |||
| end | |||
|
|
|||
| def create_database | |||
| bundle_command 'exec rake db:create db:migrate' | |||
| bundle_command 'exec rails db:create db:migrate' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Ouch... hound is barking out loud! |
spec/features/new_project_spec.rb
Outdated
| @@ -229,7 +229,9 @@ | |||
|
|
|||
| expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging") | |||
| expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1") | |||
| expect(bin_setup).to include("heroku run rake db:migrate --exit-code --app $APP_NAME") | |||
| expect(bin_setup).to( | |||
| include("heroku run rails db:migrate --exit-code --app $APP_NAME") | |||
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
spec/features/new_project_spec.rb
Outdated
| @@ -229,7 +229,9 @@ | |||
|
|
|||
| expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging") | |||
| expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1") | |||
| expect(bin_setup).to include("heroku run rake db:migrate --exit-code --app $APP_NAME") | |||
| expect(bin_setup).to( | |||
| include("heroku run rails db:migrate --exit-code --app $APP_NAME") | |||
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
spec/features/new_project_spec.rb
Outdated
| @@ -229,7 +229,9 @@ | |||
|
|
|||
| expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging") | |||
| expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1") | |||
| expect(bin_setup).to include("heroku run rake db:migrate --exit-code --app $APP_NAME") | |||
| expect(bin_setup).to( | |||
| include("heroku run rails db:migrate --exit-code --app $APP_NAME") | |||
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
spec/features/new_project_spec.rb
Outdated
| @@ -229,7 +229,9 @@ | |||
|
|
|||
| expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging") | |||
| expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1") | |||
| expect(bin_setup).to include("heroku run rake db:migrate --exit-code --app $APP_NAME") | |||
| expect(bin_setup).to( | |||
| include("heroku run rails db:migrate --exit-code --app $APP_NAME") | |||
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
|
I didn't change Heroku guide on puma (https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server) has not been updated since 2016 though. So I don't know if |
|
The puma diff has only comment changes, should be fine as is. cc @nickcharlton for review, please! Thank you. |
|
I noticed that rails 5.1 now:
So I think I can remove the |
|
Ok I did it. The git repository is now created by Rails. |
|
Have you changed hound settings? :D I'm pretty sure I had to use double quotes for strings before! |
|
@delphaber I think that the organisation config got lost on Hound and had to be reset. If you pushed again it'll rerun and be happy. |
|
@nickcharlton I pushed an empty commit, but those hound comments did not disappear from the PR. I think we can ignore them anyway, since hound check is ok! |
|
@delphaber Thanks! I went through, confirmed by eye and then deleted the invalid comments. Going to merge now! |
Update Rails to 5.1
(adds support for webpack too)