Fix fatal git failures in tests #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 10, 2017
| @@ -17,6 +17,12 @@ def run_suspenders(arguments = nil) | |||
| ` | |||
| #{suspenders_bin} #{APP_NAME} #{arguments} | |||
| ` | |||
| Dir.chdir(APP_NAME) do | |||
| with_env("HOME", tmp_path) do | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
There was a problem hiding this comment.
This file is all over the double quotes.
houndci-bot
reviewed
Mar 10, 2017
| @@ -17,6 +17,12 @@ def run_suspenders(arguments = nil) | |||
| ` | |||
| #{suspenders_bin} #{APP_NAME} #{arguments} | |||
| ` | |||
| Dir.chdir(APP_NAME) do | |||
| with_env("HOME", tmp_path) do | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
houndci-bot
reviewed
Mar 10, 2017
| @@ -17,6 +17,12 @@ def run_suspenders(arguments = nil) | |||
| ` | |||
| #{suspenders_bin} #{APP_NAME} #{arguments} | |||
| ` | |||
| Dir.chdir(APP_NAME) do | |||
| with_env("HOME", tmp_path) do | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
The tests had started printing git error messages:
```
fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
```
These were coming from three places:
- `suspenders.gemspec`, which collects all `Gem::Specification#files=`
by shelling out to `git ls-files`.
- `suspenders.gemspec`, which collects all
`Gem::Specification#test_files=` by shelling out to
`git ls-files -- {test,spec,features}/*`.
- Honeybadger, which figures out which revision to tag the error with by
invoking `rev-parse`:
def from_git
return nil unless File.directory?('.git')
`git rev-parse HEAD`.strip rescue nil
end
Although I am unsure why these things started to matter now, I found two
changes that improve the situation:
- In the test suite, make an initial commit after suspender'ing a
project.
- When suspender'ing a project, make the git repo last.
mike-burns
force-pushed
the
more-commits
branch
from
f5200e8
to
718fb7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests had started printing git error messages:
These were coming from three places:
suspenders.gemspec, which collects allGem::Specification#files=by shelling out to
git ls-files.suspenders.gemspec, which collects allGem::Specification#test_files=by shelling out togit ls-files -- {test,spec,features}/*.Honeybadger, which figures out which revision to tag the error with by
invoking
rev-parse:Although I am unsure why these things started to matter now, I found two
changes that improve the situation:
project.