Schedule Heroku Backups and Capture backup of existing staging database for Review Apps #826
Conversation
When a PR Review environment is created, the latest backup is currently used. If no backups exist, or if the backup is old and outdated, recent data used for testing may not exist. This forcibly creates a backup right before migration -- leading to the most recent data. Another way to solve this would be to automatically add `pg:backups:schedule` on all staging environments on original app scaffolding, but that would be up to 24 hours difference.
This is what I normally do on my Rails projects. Regardless of how we merge this PR, I'd like production and staging to have daily backups by default (I thought this was already the case). I don't feel strongly either way, and we can merge as is or instead turn this PR into adding the daily backup instruction on app creation, and then keeping this script as is. What do you prefer? Thanks for sharing your work! |
|
|
lib/suspenders/adapters/heroku.rb
Outdated
| ) | ||
| end | ||
| end | ||
|
|
lib/suspenders/adapters/heroku.rb
Outdated
| ) | ||
| end | ||
| end | ||
|
|
spec/adapters/heroku_spec.rb
Outdated
|
|
||
| def have_backup_schedule(remote_name) | ||
| have_received(:run). | ||
| with(/pg:backups:schedule DATABASE_URL --at '02:00 America\/Los_Angeles' --remote #{remote_name}/) |
spec/adapters/heroku_spec.rb
Outdated
| @@ -48,6 +58,11 @@ module Adapters | |||
| def app_name | |||
| SuspendersTestHelpers::APP_NAME | |||
| end | |||
|
|
|||
spec/adapters/heroku_spec.rb
Outdated
| expect(app_builder).to have_backup_schedule("staging") | ||
| expect(app_builder).to have_backup_schedule("production") | ||
| end | ||
|
|
toobulkeh
changed the title
|
This LGTM. Calling in @iwz for another review before I merge. Thank you! :) |
lib/suspenders/adapters/heroku.rb
Outdated
| def set_heroku_backup_schedule | ||
| %w(staging production).each do |environment| | ||
| run_toolbelt_command( | ||
| "pg:backups:schedule DATABASE_URL --at '02:00 America/Los_Angeles'", |
There was a problem hiding this comment.
It's the Heroku default recommended in their docs -- to convert it do you mean 2AM UTC or 10AM UTC?
There was a problem hiding this comment.
Yeah, I saw that in their docs. 10AM UTC would be fine.
spec/adapters/heroku_spec.rb
Outdated
| @@ -49,6 +59,11 @@ def app_name | |||
| SuspendersTestHelpers::APP_NAME | |||
| end | |||
|
|
|||
| def have_backup_schedule(remote_name) | |||
| have_received(:run). | |||
| with(/pg:backups:schedule DATABASE_URL --at '02:00 America\/Los_Angeles' --remote #{remote_name}/) | |||
| @@ -49,6 +59,11 @@ def app_name | |||
| SuspendersTestHelpers::APP_NAME | |||
| end | |||
|
|
|||
| def have_backup_schedule(remote_name) | |||
| have_received(:run). | |||
| with(/pg:backups:schedule DATABASE_URL --at '10:00 UTC' --remote #{remote_name}/) | |||
|
@toobulkeh this looks good to go. Do you want to clean up any commits before we merge? Also, do you think the README should mention anything about the scheduled backups? |
|
Added to the README @iwz. I'd appreciate a Squash and Merge. Is that something I can do? |
|
@toobulkeh done. thanks for implementing this! |
|
Ooh ooh ooh, good one. Shall we bump the gem version? |
|
@croaky good idea. i'm not set up for that atm, are you? |
When a PR Review environment is created, the latest backup is currently used. If no backups exist, or if the backup is old and outdated, recent data used for testing may not exist.
This forcibly creates a backup right before migration -- leading to the most recent data.
Another way to solve this would be to automatically add
pg:backups:scheduleon all staging environments on original app scaffolding, but that would be up to 24 hours difference.