-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure stylesheet_base generator runs with a clean bundle #790
Conversation
LGTM Though if bundle needs to be run after any generate maybe we could overwrite it here like:
|
Thanks for your review. Indeed. Or run on steps that modify the Gemfile. |
Added a commit which would render one of the |
Nice work, looks really good! I'm not familiar with rails generators though, does every instance var get run automatically inside |
What instance variables do you mean? |
0b176cd
to
63b1775
Compare
Static and Stylesheet suspenders' generators add gems to the `Gemfile`, but don't run `bundle install` after the fact, making installations with clean gem sets fail with errors like: ``` gemfile high_voltage generate suspenders:stylesheet_base Could not find gem 'high_voltage' in any of the gem sources listed in your Gemfile or available on this machine. Run `bundle install` to install missing gems. run bundle install Fetching gem metadata from https://rubygems.org/ Fetching version metadata from https://rubygems.org/ Fetching dependency metadata from https://rubygems.org/ Resolving dependencies... Using rake 11.2.2 ``` By adding `bundle install` calls after modifying the `Gemfile` we ensure each step will have the necessary dependencies for application code to run. [fixes #568] [fixes #787]
LGTM. |
Ah sorry @tute, I meant instance methods (:install_refills, :install_bitters). Was getting late over here last night, I don't know how you do it ;) I'm gonna assume it's a meta thing. |
Yes, public methods defined in the class execute when the generator is run. |
Static and Stylesheet suspenders' generators add gems to the
Gemfile
,but don't run
bundle install
after the fact, making installations withclean gem sets fail with errors like:
By adding
bundle install
calls after modifying theGemfile
we ensureeach step will have the necessary dependencies for application code to
run.
[fixes #568]
[fixes #787]