README: Update instructions for generating a new app #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1221 The [release of Rails 7.2.0][rails_7_2] introduced its [own linting mechanism][rails-lint]. Unfortunately, this creates a conflict with [our linting mechanism][suspenders-lint]. This is only relevant when running `rails new` with our [application template][]. In order to fix this, we simply require the caller pass `--skip_rubocop`. A future commit could explore re-introducing the system executable to account for our required options, but for now, this fixes the issue. [rails_7_2]: https://guides.rubyonrails.org/v7.2/7_2_release_notes.html [rails-lint]: https://guides.rubyonrails.org/v7.2/7_2_release_notes.html#add-omakase-rubocop-rules-by-default [suspenders-lint]: https://github.com/thoughtbot/suspenders/blob/main/FEATURES.md#linting [application template]: https://github.com/thoughtbot/suspenders/blob/main/lib/install/web.rb
stevepolitodesign
force-pushed
the
sp-1221
branch
from
00a7e0e to
23d3354
Compare
stevepolitodesign
added a commit
to thoughtbot/dotfiles
that referenced
this pull request
Aug 16, 2024
This compliments a [change made to Suspenders][1] in which we require the caller to pass `--skip-rubocop` when invoking `rails new`. [1]: thoughtbot/suspenders#1223
kkelleey
pushed a commit
to kkelleey/dotfiles
that referenced
this pull request
Oct 8, 2024
This compliments a [change made to Suspenders][1] in which we require the caller to pass `--skip-rubocop` when invoking `rails new`. [1]: thoughtbot/suspenders#1223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1221
The release of Rails 7.2.0 introduced its own linting mechanism.
Unfortunately, this creates a conflict with our linting mechanism.
This is only relevant when running
rails newwith our application template.In order to fix this, we simply require the caller pass
--skip_rubocop.A future commit could explore re-introducing the system executable to
account for our required options, but for now, this fixes the issue.