Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call dynamic-readme reusable workflow #1165

Closed
wants to merge 2 commits into from

Conversation

stefannibrasil
Copy link

We want to have a way to edit our README footer at one place and have the changes from there be propagated to our repos.

By adding this snippet in the README, we call this reusable workflow: https://github.com/thoughtbot/templates/blob/main/.github/workflows/dynamic-readme.yaml that renders and updates the README footer dynamically.

We want to have a way to edit our README footer at one place and have the changes from there be propagated to our repos.

By adding this snippet in the README, we call this reusable workflow: https://github.com/thoughtbot/templates/blob/main/.github/workflows/dynamic-readme.yaml that renders and updates the README footer dynamically.
@stefannibrasil
Copy link
Author

@stevepolitodesign any tips on how to make CI happy? 👀

@stevepolitodesign
Copy link
Contributor

@stefannibrasil I've noticed CI failures on new pull requests made against main made after I started working on Suspenders 3.0.0. I think this is because the new branch introduced an updated ci.yml script.

For now, how would you feel about making this pull request against suspenders-3-0-0, since it's almost ready?

@stefannibrasil
Copy link
Author

Got it, thanks! Moved the commit to the suspenders-3-0-0 branch: https://github.com/thoughtbot/suspenders/compare/dynamic-readme-workflow?expand=1

@stefannibrasil stefannibrasil deleted the sb-dynamic-readme-workflow branch March 18, 2024 16:19
@stevepolitodesign
Copy link
Contributor

@stefannibrasil we're at a point where we can reopen this if you still feel it's worth doing 👍

@stefannibrasil
Copy link
Author

Thanks, Steve! I can't reopen the branch anymore, so I created a new PR: #1208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants