- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce suspenders:inline_svg
generator
#1140
Introduce suspenders:inline_svg
generator
#1140
Conversation
07772d1
to
60a8075
Compare
suspenders:inline_svg
generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for not only taking care of this, but live steaming it too. I just had a few comments, but nothing blocking.
class InlineSvgGenerator < Rails::Generators::Base | ||
include Suspenders::Generators::APIAppUnsupported | ||
source_root File.expand_path("../../templates/inline_svg", __FILE__) | ||
desc "Installs inline_svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have mentioned this in the contributing section of the pull request description, but the current release has descriptions. We might want to use the existing description for consistency's sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll change it here and in the documentation.
README.md
Outdated
|
||
Installs [inline_svg] | ||
|
||
`./bin/rails g suspenders:inline_svg` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Minor]
#1141 will remove the ./
. We might want to address that here too.
`./bin/rails g suspenders:inline_svg` | |
`bin/rails g suspenders:inline_svg` |
README.md
Outdated
@@ -30,6 +30,14 @@ Installs [capybara_accessibility_audit] and [capybara_accessible_selectors] | |||
[capybara_accessibility_audit]: https://github.com/thoughtbot/capybara_accessibility_audit | |||
[capybara_accessible_selectors]: https://github.com/citizensadvice/capybara_accessible_selectors | |||
|
|||
### Inline SVG | |||
|
|||
Installs [inline_svg] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we end up updating the description, we might want to update it here too.
Ports the existing generator to Suspenders 3.0.
60a8075
to
311d4a8
Compare
Ports the existing generator to Suspenders 3.0.
Ports the existing generator to Suspenders 3.0.
To do:
How to test manually
Add suspenders to the
Gemfile
.Install and run the generator: