Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce suspenders:advisories generator #1138

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

stevepolitodesign
Copy link
Contributor

@stevepolitodesign stevepolitodesign commented Nov 6, 2023

Uses the bundler-audit gem to update the local security database and
show any relevant issues with the app's dependencies. This generator is
only responsible for installing the gem.

The original implementation was written in 2014, and is no longer
relevant. This is because the gem ships with a Rake task that can be
set as the default task, which will be addressed in #1144

Also exposes backup_file and restore_file test helpers into the
public API.

@stevepolitodesign stevepolitodesign changed the base branch from main to suspenders-3-0-0 November 6, 2023 12:51
stevepolitodesign added a commit that referenced this pull request Nov 11, 2023
Closes #1138
Closes #1143

Consolidates logic from the existing [advisories][] and [lint][]
generators to create a default Rake task that audits and lints the
codebase.

We do this because it's simpler to bundle this configuration together,
rather than have two separate generators compete to modify the default
Rake task, since those generators can be run independently.

[advisories]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/advisories_generator.rb
[lint]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/lint_generator.rb
stevepolitodesign added a commit that referenced this pull request Nov 11, 2023
Closes #1138
Closes #1143

Consolidates logic from the existing [advisories][] and [lint][]
generators to create a default Rake task that audits and lints the
codebase.

We do this because it's simpler to bundle this configuration together,
rather than have two separate generators compete to modify the default
Rake task, since those generators can be run independently.

[advisories]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/advisories_generator.rb
[lint]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/lint_generator.rb
stevepolitodesign added a commit that referenced this pull request Nov 11, 2023
Closes #1138
Closes #1143

Consolidates logic from the existing [advisories][] and [lint][]
generators to create a default Rake task that audits and lints the
codebase.

We do this because it's simpler to bundle this configuration together,
rather than have two separate generators compete to modify the default
Rake task, since those generators can be run independently.

[advisories]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/advisories_generator.rb
[lint]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/lint_generator.rb
@stevepolitodesign stevepolitodesign force-pushed the advisories_generator branch 4 times, most recently from 5ee7eed to 3dc2fe1 Compare November 28, 2023 01:06
Uses the [bundler-audit][] gem to update the local security database and
show any relevant issues with the app's dependencies. This generator is
only responsible for installing the gem and adding the Rake task.

The [original implementation][] was written in 2014, and is no longer
relevant. This is because the gem ships [with a Rake task][] that can be
set as the default task, which will be addressed in #1144

Also exposes `backup_file` and `restore_file` test helpers into the
public API.

[bundler-audit]: https://github.com/rubysec/bundler-audit
[original implementation]: e23157e
[with a Rake task]: https://github.com/rubysec/bundler-audit#rake-tasks
@stevepolitodesign stevepolitodesign merged commit 74603ad into suspenders-3-0-0 Nov 28, 2023
2 checks passed
@stevepolitodesign stevepolitodesign deleted the advisories_generator branch November 28, 2023 01:40
stevepolitodesign added a commit that referenced this pull request May 10, 2024
Uses the [bundler-audit][] gem to update the local security database and
show any relevant issues with the app's dependencies. This generator is
only responsible for installing the gem and adding the Rake task.

The [original implementation][] was written in 2014, and is no longer
relevant. This is because the gem ships [with a Rake task][] that can be
set as the default task, which will be addressed in #1144

Also exposes `backup_file` and `restore_file` test helpers into the
public API.

[bundler-audit]: https://github.com/rubysec/bundler-audit
[original implementation]: e23157e
[with a Rake task]: https://github.com/rubysec/bundler-audit#rake-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant